Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement registered reactions pagination #476

Merged
merged 16 commits into from
Jun 11, 2021
Merged

Implement registered reactions pagination #476

merged 16 commits into from
Jun 11, 2021

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Jun 10, 2021 •
edited
Loading

Description

This PR is the implementation of #471 .
Close #471

The changing includes:

  • Swap short code and subspace in store key
  • Add subspace and pagination fields to registered reactions query
  • Revise grpc query and cli of registered reactions

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov
Copy link

codecov bot commented Jun 10, 2021 •
edited
Loading

Codecov Report

Merging #476 (51c9c1a) into master (16e1eeb) will increase coverage by 8.48%.
The diff coverage is 88.30%.

❗ Current head 51c9c1a differs from pull request most recent head 91b54ed. Consider uploading reports for the commit 91b54ed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   75.59%   84.07%   +8.48%     
==========================================
  Files          94       91       -3     
  Lines        4519     4100     -419     
==========================================
+ Hits         3416     3447      +31     
+ Misses        960      503     -457     
- Partials      143      150       +7
Impacted Files Coverage Δ
x/commons/commons.go 100.00% <ø> (ø)
x/staging/posts/simulation/decoder.go 94.87% <ø> (ø)
x/staging/subspaces/types/codec.go 0.00% <0.00%> (ø)
x/staging/subspaces/types/query.go 0.00% <0.00%> (ø)
x/staging/subspaces/keeper/invariants.go 58.82% <58.82%> (ø)
x/profiles/keeper/keeper_relationships.go 83.87% <64.28%> (-16.13%) ⬇️
x/profiles/client/cli/cli_relationships.go 79.16% <66.66%> (-2.66%) ⬇️
x/profiles/keeper/grpc_query.go 76.19% <69.23%> (+3.11%) ⬆️
x/staging/subspaces/simulation/decoder.go 77.77% <77.77%> (ø)
x/profiles/keeper/alias_functions.go 87.50% <83.33%> (+2.88%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb3a8a...91b54ed. Read the comment docs.

@dadamu dadamu force-pushed the paul/registered-reactions-pagination branch from e9af11a to e6bd149 Compare June 10, 2021 13:49
RiccardoM
RiccardoM reviewed Jun 11, 2021
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, can you please add a CHANGELOG entry as well?

x/staging/posts/types/keys.go Outdated Show resolved Hide resolved
x/staging/posts/types/keys.go Outdated Show resolved Hide resolved
x/staging/posts/types/keys.go Outdated Show resolved Hide resolved
leobragaz
leobragaz approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@RiccardoM RiccardoM merged commit a9d2162 into master Jun 11, 2021
@RiccardoM RiccardoM deleted the paul/registered-reactions-pagination branch June 11, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

@leobragaz leobragaz leobragaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the pagination to RegisteredReactions
3 participants
@dadamu @RiccardoM @leobragaz